Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Split Toolpad documentation #41316

Merged
merged 9 commits into from
Mar 15, 2024

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap commented Feb 29, 2024

@bharatkashyap bharatkashyap added the docs Improvements or additions to the documentation label Feb 29, 2024
@mui-bot
Copy link

mui-bot commented Feb 29, 2024

Netlify deploy preview

https://deploy-preview-41316--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3a0875b

@zannager zannager requested a review from Janpot February 29, 2024 14:18
@bharatkashyap bharatkashyap added the website Pages that are not documentation-related, marketing-focused. label Mar 7, 2024
@bharatkashyap bharatkashyap changed the title [docs] Split Toolpad documentation [docs] [docs] Split Toolpad documentation Mar 7, 2024
@bharatkashyap bharatkashyap changed the title [docs] [docs] Split Toolpad documentation [docs] [website] Split Toolpad documentation Mar 7, 2024
@danilo-leal danilo-leal changed the title [docs] [website] Split Toolpad documentation [website] Split Toolpad documentation Mar 14, 2024
@danilo-leal danilo-leal added Toolpad and removed docs Improvements or additions to the documentation labels Mar 14, 2024
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you're waiting for something, but it looks good to me!

@bharatkashyap bharatkashyap merged commit ba9baae into mui:master Mar 15, 2024
22 checks passed
@@ -15,7 +15,7 @@ swap:
MUI System: MUI System
MUI Store: MUI Store
MUI Core: MUI Core
MUI Toolpad: MUI Toolpad
Toolpad: Toolpad
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Toolpad: Toolpad
MUI Toolpad: Toolpad
MUI Toolpad: Toolpad

handled in #41516.

Comment on lines +54 to +62
if (firstFolder === 'toolpad') {
productCategoryId = 'toolpad';
const secondFolder = asPathWithoutLang.replace(/^\/+[^/]+\/([^/]+)\/.*/, '$1');
if (secondFolder === 'studio') {
productId = 'toolpad-studio';
} else {
productId = 'toolpad-core';
}
}
Copy link
Member

@oliviertassinari oliviertassinari Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharatkashyap Can we fix MuiProductId and MuiProductCategoryId? These types are wrong now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Toolpad website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants